[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gmp-devel
Subject:    mini-gmp and mpq
From:       marc.glisse () inria ! fr (Marc Glisse)
Date:       2018-02-28 20:20:46
Message-ID: alpine.DEB.2.21.1802282054510.22122 () stedding ! saclay ! inria ! fr
[Download RAW message or body]

On Wed, 28 Feb 2018, Marco Bodrato wrote:

>> Something like that, yes. But it feels like this is duplicating
>> functionality that should be elsewhere... Bah, I am probably too picky for
>> so few lines, feel free to go ahead and commit your patch (I don't
>
> Pushed it.
>
>> remember if any of the tests do q+1).
>
> I hope I added them with another patch:
> https://gmplib.org/repo/gmp/rev/7cae59f06a21

Yes, I think that works.

> In the meanwhile I also pushed some small shortcuts for __gmp_binary_equal
> applied to mpq and integers: https://gmplib.org/repo/gmp/rev/a22c11d52f05

Thanks, that's a good idea. If we wanted to, we could also specialize the 
test q == 0 (and q < 0), which is probably common enough, but that's 
independent, and a negligible gain.

-- 
Marc Glisse

[prev in list] [next in list] [prev in thread] [next in thread]