[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gmp-bugs
Subject:    generic/dive_1.c line 121
From:       tg () gmplib ! org (=?utf-8?Q?Torbj=C3=B6rn?= Granlund)
Date:       2016-11-01 16:48:04
Message-ID: 86y413jge3.fsf () shell ! gmplib ! org
[Download RAW message or body]

Peter Barfuss <pbarfuss at csclub.uwaterloo.ca> writes:

  Looking at generic/dive_1.c, this line stuck out as, uh, what on earth:
  https://gmplib.org/repo/gmp-6.1/file/tip/mpn/generic/dive_1.c#l121
  
  Based on the contents of this patchset:
  https://gmplib.org/repo/gmp-6.1/rev/f00b33194300
  
  it indeed looks very superfluous, at best.

It is not only superfluous, it is also redundant, needless and
unneccessary.

  Also nearest I can tell
  there are no tests for mpn_divexact or mpn_divexact_1???
  
Not unit-tested by 'make check' (something they share with dozen of
other low-level functions).  But as evidenced by our coverage analysis
they are indirectly tested:

https://gmplib.org/devel/lcov/
  

-- 
Torbj?rn
Please encrypt, key id 0xC8601622

[prev in list] [next in list] [prev in thread] [next in thread]