[prev in list] [next in list] [prev in thread] [next in thread]
List: gluster-devel
Subject: Re: [Gluster-devel] [Gluster-infra] Please test Gerrit 2.12.2
From: Nigel Babu <nigelb () redhat ! com>
Date: 2016-05-31 7:26:41
Message-ID: CAF2NqgM9=vVs5RZN=Y=YUe2RBtHLG6Lg4Bm7Hp0JK+0Au3RKEA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hello,
I'm guessing there's a particular combination of permissions you need to
see
the Fix button. I don't see it myself, possibly because I don't have any
changes made by me nor has my user been marked as a reviewer for any commit.
The security issue and the "Fix" button are unrelated as far as I know. The
security issue was fixed in apache-commons collections rather than Gerrit
code.
Thank you for testing! :)
On Tue, May 31, 2016 at 12:42 PM, Anoop C S <anoopcs@redhat.com> wrote:
> On Tue, 2016-05-31 at 03:09 -0400, Kotresh Hiremath Ravishankar wrote:
> > Hi Prasanna,
> >
> > 'Fix' button is visible. May be you are missing something, please
> > check.
> >
>
> +1
>
> > Thanks and Regards,
> > Kotresh H R
> >
> > ----- Original Message -----
> > >
> > > From: "Prasanna Kalever" <pkalever@redhat.com>
> > > To: "Nigel Babu" <nigelb@redhat.com>
> > > Cc: "gluster-infra" <gluster-infra@gluster.org>, "gluster-devel" <g
> > > luster-devel@gluster.org>
> > > Sent: Tuesday, May 31, 2016 12:13:47 PM
> > > Subject: Re: [Gluster-devel] [Gluster-infra] Please test Gerrit
> > > 2.12.2
> > >
> > > Hi Nigel,
> > >
> > > I don't see 'Fix' button in the comment section which is "fix for a
> > > remote code execution exploit" introduced in 2.12.2, it helps us in
> > > editing the code in the gerrit web editor instantaneously, hence we
> > > don't have to cherry pick the patch every time to address minor
> > > code
> > > changes.
> > >
> > > I feel that is really helpful for the developers to address
> > > comments
> > > faster and easier.
> > >
> > > Please see [1], it also has attachments showing how this looks
> > >
> > > [1] http://www.gluster.org/pipermail/gluster-devel/2016-May/049429.
> > > html
> > >
> > >
> > > Thanks,
> > > --
> > > Prasanna
> > >
> > > On Tue, May 31, 2016 at 10:39 AM, Nigel Babu <nigelb@redhat.com>
> > > wrote:
> > > >
> > > > Hello,
> > > >
> > > > A reminder: I'm hoping to get this done tomorrow morning at 0230
> > > > GMT[1].
> > > > I'll have a backup ready in case something goes wrong. I've
> > > > tested this
> > > > process on review.nigelb.me and it's gone reasonably smoothly.
> > > >
> > > > [1]:
> > > > http://www.timeanddate.com/worldclock/fixedtime.html?msg=Maintena
> > > > nce&iso=20160601T08&p1=176&ah=1
> > > >
> > > > On Mon, May 30, 2016 at 7:26 PM, Nigel Babu <nigelb@redhat.com>
> > > > wrote:
> > > > >
> > > > >
> > > > > Hello,
> > > > >
> > > > > I've now upgraded Gerrit on http://review.nigelb.me to 2.12.2.
> > > > > Please
> > > > > spend a few minutes testing that everything works as you expect
> > > > > it to. If
> > > > > I
> > > > > don't hear anything negative by tomorrow, I'd like to schedule
> > > > > an upgrade
> > > > > this week.
> > > > >
> > > > > --
> > > > > nigelb
> > > >
> > > >
> > > >
> > > > --
> > > > nigelb
> > > >
> > > > _______________________________________________
> > > > Gluster-infra mailing list
> > > > Gluster-infra@gluster.org
> > > > http://www.gluster.org/mailman/listinfo/gluster-infra
> > > _______________________________________________
> > > Gluster-devel mailing list
> > > Gluster-devel@gluster.org
> > > http://www.gluster.org/mailman/listinfo/gluster-devel
> > >
> > _______________________________________________
> > Gluster-devel mailing list
> > Gluster-devel@gluster.org
> > http://www.gluster.org/mailman/listinfo/gluster-devel
> _______________________________________________
> Gluster-infra mailing list
> Gluster-infra@gluster.org
> http://www.gluster.org/mailman/listinfo/gluster-infra
>
--
nigelb
[Attachment #5 (text/html)]
<div dir="ltr">Hello,<br><div><br>I'm guessing there's a particular \
combination of permissions you need to see <br>the Fix button. I don't see it \
myself, possibly because I don't have any <br>changes made by me nor has my user \
been marked as a reviewer for any commit.<br><br>The security issue and the \
"Fix" button are unrelated as far as I know. The <br>security issue was \
fixed in apache-commons collections rather than Gerrit code.<br><br></div><div>Thank \
you for testing! :)<br></div><div class="gmail_extra"><br><div class="gmail_quote">On \
Tue, May 31, 2016 at 12:42 PM, Anoop C S <span dir="ltr"><<a \
href="mailto:anoopcs@redhat.com" target="_blank">anoopcs@redhat.com</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><span>On Tue, 2016-05-31 at 03:09 -0400, Kotresh \
Hiremath Ravishankar wrote:<br> > Hi Prasanna,<br>
><br>
> 'Fix' button is visible. May be you are missing something, please<br>
> check.<br>
><br>
<br>
</span>+1<br>
<div><div><br>
> Thanks and Regards,<br>
> Kotresh H R<br>
><br>
> ----- Original Message -----<br>
> ><br>
> > From: "Prasanna Kalever" <<a href="mailto:pkalever@redhat.com" \
target="_blank">pkalever@redhat.com</a>><br> > > To: "Nigel Babu" \
<<a href="mailto:nigelb@redhat.com" target="_blank">nigelb@redhat.com</a>><br> \
> > Cc: "gluster-infra" <<a \
href="mailto:gluster-infra@gluster.org" \
target="_blank">gluster-infra@gluster.org</a>>, "gluster-devel" \
<g<br> > > <a href="mailto:luster-devel@gluster.org" \
target="_blank">luster-devel@gluster.org</a>><br> > > Sent: Tuesday, May 31, \
2016 12:13:47 PM<br> > > Subject: Re: [Gluster-devel] [Gluster-infra] Please \
test Gerrit<br> > > 2.12.2<br>
> ><br>
> > Hi Nigel,<br>
> ><br>
> > I don't see 'Fix' button in the comment section which is \
"fix for a<br> > > remote code execution exploit" introduced in \
2.12.2, it helps us in<br> > > editing the code in the gerrit web editor \
instantaneously, hence we<br> > > don't have to cherry pick the patch every \
time to address minor<br> > > code<br>
> > changes.<br>
> ><br>
> > I feel that is really helpful for the developers to address<br>
> > comments<br>
> > faster and easier.<br>
> ><br>
> > Please see [1], it also has attachments showing how this looks<br>
> ><br>
> > [1] <a href="http://www.gluster.org/pipermail/gluster-devel/2016-May/049429" \
rel="noreferrer" target="_blank">http://www.gluster.org/pipermail/gluster-devel/2016-May/049429</a>.<br>
> > html<br>
> ><br>
> ><br>
> > Thanks,<br>
> > --<br>
> > Prasanna<br>
> ><br>
> > On Tue, May 31, 2016 at 10:39 AM, Nigel Babu <<a \
href="mailto:nigelb@redhat.com" target="_blank">nigelb@redhat.com</a>><br> > \
> wrote:<br> > > ><br>
> > > Hello,<br>
> > ><br>
> > > A reminder: I'm hoping to get this done tomorrow morning at \
0230<br> > > > GMT[1].<br>
> > > I'll have a backup ready in case something goes wrong. \
I've<br> > > > tested this<br>
> > > process on <a href="http://review.nigelb.me" rel="noreferrer" \
target="_blank">review.nigelb.me</a> and it's gone reasonably smoothly.<br> > \
> ><br> > > > [1]:<br>
> > > <a href="http://www.timeanddate.com/worldclock/fixedtime.html?msg=Maintena" \
rel="noreferrer" target="_blank">http://www.timeanddate.com/worldclock/fixedtime.html?msg=Maintena</a><br>
> > > nce&iso=20160601T08&p1=176&ah=1<br>
> > ><br>
> > > On Mon, May 30, 2016 at 7:26 PM, Nigel Babu <<a \
href="mailto:nigelb@redhat.com" target="_blank">nigelb@redhat.com</a>><br> > \
> > wrote:<br> > > > ><br>
> > > ><br>
> > > > Hello,<br>
> > > ><br>
> > > > I've now upgraded Gerrit on <a href="http://review.nigelb.me" \
rel="noreferrer" target="_blank">http://review.nigelb.me</a> to 2.12.2.<br> > > \
> > Please<br> > > > > spend a few minutes testing that everything \
works as you expect<br> > > > > it to. If<br>
> > > > I<br>
> > > > don't hear anything negative by tomorrow, I'd like to \
schedule<br> > > > > an upgrade<br>
> > > > this week.<br>
> > > ><br>
> > > > --<br>
> > > > nigelb<br>
> > ><br>
> > ><br>
> > ><br>
> > > --<br>
> > > nigelb<br>
> > ><br>
> > > _______________________________________________<br>
> > > Gluster-infra mailing list<br>
> > > <a href="mailto:Gluster-infra@gluster.org" \
target="_blank">Gluster-infra@gluster.org</a><br> > > > <a \
href="http://www.gluster.org/mailman/listinfo/gluster-infra" rel="noreferrer" \
target="_blank">http://www.gluster.org/mailman/listinfo/gluster-infra</a><br> > \
> _______________________________________________<br> > > Gluster-devel \
mailing list<br> > > <a href="mailto:Gluster-devel@gluster.org" \
target="_blank">Gluster-devel@gluster.org</a><br> > > <a \
href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" \
target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br> > \
><br> > _______________________________________________<br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@gluster.org" \
target="_blank">Gluster-devel@gluster.org</a><br> > <a \
href="http://www.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" \
target="_blank">http://www.gluster.org/mailman/listinfo/gluster-devel</a><br> \
_______________________________________________<br> Gluster-infra mailing list<br>
<a href="mailto:Gluster-infra@gluster.org" \
target="_blank">Gluster-infra@gluster.org</a><br> <a \
href="http://www.gluster.org/mailman/listinfo/gluster-infra" rel="noreferrer" \
target="_blank">http://www.gluster.org/mailman/listinfo/gluster-infra</a><br> \
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div \
data-smartmail="gmail_signature"><div dir="ltr">nigelb<br></div></div> </div></div>
_______________________________________________
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic