[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-help
Subject:    [PATCH] build_wcs_upper_buffer definition
From:       carlos () systemhalted ! org (Carlos O'Donell)
Date:       2008-11-26 19:48:00
Message-ID: 119aab440811261147k32f7837fkf29691c983fe849c () mail ! gmail ! com
[Download RAW message or body]

On Wed, Nov 26, 2008 at 2:23 PM, Chris Steel
<chris.steel.lnx@googlemail.com> wrote:
> build_wcs_upper_buffer is defined in posix/regex_internal.h to have a
> return type of int, but it's used in posix/regex_internal.c and
> posix/regexec.c with a return type of reg_errcode_t. This patch fixes
> the problem:

You will need to write a proper GNU ChangeLog for your patch, and it
would be good to show that the testsuite shows no regressions e.g. run
the testsuite before your patch, and after, with no difference.

With those changes I think your patch should be good to go on libc-alpha.

Cheers,
Carlos.


[prev in list] [next in list] [prev in thread] [next in thread]