[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-cvs
Subject:    [glibc] benchtests: fix warn unused result
From:       Siddhesh Poyarekar via Glibc-cvs <glibc-cvs () sourceware ! org>
Date:       2023-06-22 4:54:02
Message-ID: 20230622045402.36E25385841D () sourceware ! org
[Download RAW message or body]

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=99f9ae4ed0ba9f2c84520b78fd0eeed96a7ed40e


commit 99f9ae4ed0ba9f2c84520b78fd0eeed96a7ed40e
Author: Frederic Berat <fberat@redhat.com>
Date:   Tue Jun 20 20:19:09 2023 +0200

    benchtests: fix warn unused result
    
    Few tests needed to properly check for asprintf and system calls return
    values with _FORTIFY_SOURCE enabled.
    
    Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

Diff:
---
 benchtests/bench-strcoll.c                            | 6 +++++-
 sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c | 3 ++-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/benchtests/bench-strcoll.c b/benchtests/bench-strcoll.c
index b3cd5ce8a9..0bd9ada5f6 100644
--- a/benchtests/bench-strcoll.c
+++ b/benchtests/bench-strcoll.c
@@ -254,7 +254,11 @@ main (void)
 	}
 
       char *filename;
-      asprintf (&filename, INPUT_PREFIX "%s", input_files[i]);
+      if (asprintf (&filename, INPUT_PREFIX "%s", input_files[i]) < 0)
+	{
+	  printf ("asprintf failed, aborting!\n");
+	  return ERROR_FILENAME;
+	}
       result = bench_file (json_ctx, input_files[i], filename, locale + 1);
 
       if (result != OK)
diff --git a/sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c \
b/sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c index e5cdb2b2a1..4631ec9f0b \
                100644
--- a/sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c
+++ b/sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c
@@ -24,6 +24,7 @@
 #include <sys/types.h>
 #include <sys/uio.h>
 #include <elf.h>
+#include <support/xstdlib.h>
 #include <support/xunistd.h>
 #include <support/check.h>
 #include <string.h>
@@ -44,7 +45,7 @@ tracee_func (int pid)
   char str[80];
   sprintf (str, "cat /proc/%d/maps", pid);
   puts (str);
-  system (str);
+  xsystem (str);
   fflush (stdout);
 
   TEST_VERIFY_EXIT (ptrace (PTRACE_TRACEME) == 0);


[prev in list] [next in list] [prev in thread] [next in thread]