[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-cvs
Subject:    [glibc] hurd: Simplify _hurd_critical_section_lock a bit
From:       Samuel Thibault via Glibc-cvs <glibc-cvs () sourceware ! org>
Date:       2023-04-29 14:50:31
Message-ID: 20230429145031.D8E453858C50 () sourceware ! org
[Download RAW message or body]

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c287ecd99133cd82413ad99f2f167628b2df670c

commit c287ecd99133cd82413ad99f2f167628b2df670c
Author: Sergey Bugaev <bugaevc@gmail.com>
Date:   Sat Apr 29 16:13:48 2023 +0300

    hurd: Simplify _hurd_critical_section_lock a bit
    
    This block of code was doing exactly what _hurd_self_sigstate does; so
    just call that and let it do its job.
    
    Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
    Message-Id: <20230429131354.2507443-1-bugaevc@gmail.com>

Diff:
---
 hurd/hurd/signal.h | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/hurd/hurd/signal.h b/hurd/hurd/signal.h
index 662e955e94..b8af6f289a 100644
--- a/hurd/hurd/signal.h
+++ b/hurd/hurd/signal.h
@@ -170,6 +170,11 @@ _hurd_self_sigstate (void)
   if (__glibc_unlikely (ss == NULL))
     {
       thread_t self = __mach_thread_self ();
+
+      /* The thread variable is unset; this must be the first time we've
+        asked for it.  In this case, the critical section flag cannot
+        possible already be set.  Look up our sigstate structure the slow
+        way.  */
       ss = _hurd_thread_sigstate (self);
       THREAD_SETMEM (THREAD_SELF, _hurd_sigstate, ss);
       __mach_port_deallocate (__mach_task_self (), self);
@@ -218,19 +223,7 @@ _hurd_critical_section_lock (void)
     return NULL;
 #endif
 
-  ss = THREAD_GETMEM (THREAD_SELF, _hurd_sigstate);
-  if (ss == NULL)
-    {
-      thread_t self = __mach_thread_self ();
-
-      /* The thread variable is unset; this must be the first time we've
-	 asked for it.  In this case, the critical section flag cannot
-	 possible already be set.  Look up our sigstate structure the slow
-	 way.  */
-      ss = _hurd_thread_sigstate (self);
-      THREAD_SETMEM (THREAD_SELF, _hurd_sigstate, ss);
-      __mach_port_deallocate (__mach_task_self (), self);
-    }
+  ss = _hurd_self_sigstate ();
 
   if (! __spin_try_lock (&ss->critical_section_lock))
     /* We are already in a critical section, so do nothing.  */
[prev in list] [next in list] [prev in thread] [next in thread]