[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-alpha
Subject:    Re: [PATCH] Make sure INSTALL is ASCII plaintext again
From:       Mark Wielaard <mark () klomp ! org>
Date:       2024-04-30 9:36:02
Message-ID: ada022abe8049d617485fd139ed9eb7def4dc97a.camel () klomp ! org
[Download RAW message or body]

Hi,

On Mon, 2024-04-29 at 14:53 +0200, Florian Weimer wrote:
> Looks reasonable, thanks.
> 
> Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks, pushed as:

commit ebfd73a80f15559fe59fee32a7844c6b8fa99576
Author: Mark Wielaard <mark@klomp.org>
Date:   Sun Apr 28 16:59:39 2024 +0200

    Make sure INSTALL is ASCII plaintext again
    
    This reverts commit 84e93afc7 ("Switch to UTF-8 for INSTALL") and
    reinstates commit c14f2e4aa ("Make sure INSTALL is ASCII plaintext")
    and regenerates INSTALL.
    
    It turns out that different versions of makeinfo (texinfo/texi2any),
    at least versions 7.0.3 and 7.1, put unicode quote glyphs in different
    places (specifically whether contractions like you'd, don't, aren't or
    you'll use ' or '). This breaks the make dist target as used for
    (snapshot) releases, which have a check on the regenerated INSTALL
    file. Using --disable-encoding generates the same plaintext ASCII on
    all versions.
    
    An alternative would be to regenerate INSTALL with texinfo 7.1 and
    require at least that version. But that seems too soon while various
    distros don't have 7.1 yet. We can try again to use UTF-8 for INSTALL
    in a couple of years.
    
    Reviewed-by: Florian Weimer <fweimer@redhat.com>

This makes the snapshots builder green again:
https://builder.sourceware.org/buildbot/#/builders/glibc-snapshots-trunk
https://snapshots.sourceware.org/glibc/trunk/latest/

Cheers,

Mark
[prev in list] [next in list] [prev in thread] [next in thread]