[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-alpha
Subject:    Re: [PATCH] v3: Use gcc __builtin_stdc_* builtins in stdbit.h if possible
From:       Joseph Myers <josmyers () redhat ! com>
Date:       2024-01-29 21:07:08
Message-ID: 23ea145a-5250-3770-9789-c48ea4b417eb () redhat ! com
[Download RAW message or body]

On Fri, 26 Jan 2024, Jakub Jelinek wrote:

> So like this then (only stdbit.texi changed since last patch)?

Yes.

> +ui
> +leading_zeros (uc a, us b, ui c, ul d, ull e)
> +{
> +  return (stdc_leading_zeros (a)
> +	  + stdc_leading_zeros (b)
> +	  + stdc_leading_zeros (c)
> +	  + stdc_leading_zeros (d)
> +	  + stdc_leading_zeros (e));
> +}

I don't see what these functions are for.  They don't seem to be used at 
all, and the existing tests thoroughly cover the type-generic macros as 
applied to non-_BitInt types, so additional tests that only verify that 
such calls can be compiled for non-_BitInt types don't seem to add much 
value.

-- 
Joseph S. Myers
josmyers@redhat.com

[prev in list] [next in list] [prev in thread] [next in thread]