[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-alpha
Subject:    Re: [PATCH] riscv: Use __has_include__ to include <asm/syscalls.h> [BZ #24022]
From:       "H.J. Lu" <hjl.tools () gmail ! com>
Date:       2018-12-31 18:32:44
Message-ID: CAMe9rOrrzKGxrDj1bLrtW1CZZJZ03Os_b7DUr+OjMA2nQdS1PQ () mail ! gmail ! com
[Download RAW message or body]

On Mon, Dec 31, 2018 at 10:25 AM Florian Weimer <fw@deneb.enyo.de> wrote:
>
> * H. J. Lu:
>
> > On Mon, Dec 31, 2018 at 9:36 AM Florian Weimer <fw@deneb.enyo.de> wrote:
> >>
> >> * H. J. Lu:
> >>
> >> > +#if __has_include__ (<asm/syscalls.h>)
> >>
> >> Isn't __has_include (no trailing __) the more canonical name?
> >> I think that's what's in C++17.
> >
> > I think __has_include__ is OK for glibc internal source.
>
> Both are accepted by the compiler.  But I want to reduce cognitive
> load for the reader, and avoid use unportable constructs when
> prefectly portable ones exist.

Fine with me.

-- 
H.J.
[prev in list] [next in list] [prev in thread] [next in thread]