[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-alpha
Subject:    Re: [PATCH v2 1/3] Remove unneeded declarations from math_private.h
From:       Joseph Myers <joseph () codesourcery ! com>
Date:       2017-03-29 14:25:20
Message-ID: alpine.DEB.2.20.1703291423260.17434 () digraph ! polyomino ! org ! uk
[Download RAW message or body]

On Tue, 28 Mar 2017, Gabriel F. T. Gomes wrote:

> The declarations of many functions in math_private.h are not required
> since __MATHDECL and __MATHDECLX, in math.h, already provide the
> declarations for these functions.  This patch removes the declarations
> from math_private.h. It also adds the inclusion of math.h to the files
> which depended on the declaration of functions in math_private.h.
> 
> Tested for powerpc64le and s390x.

OK apart from the removal of the inline definition of __copysignl.  That 
inline definition is still relevant in the absence of changing all calls 
to __copysign* to call copysign* directly so the compiler can inline them 
(and if changed to call copysign*, which I think would make sense, it 
would be desirable to run build-many-glibcs.py tests to make sure this 
doesn't introduce linknamespace issues).

-- 
Joseph S. Myers
joseph@codesourcery.com
[prev in list] [next in list] [prev in thread] [next in thread]