[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-alpha
Subject:    Re: [PATCH] fix to malloc checking
From:       Siddhesh Poyarekar <siddhesh () redhat ! com>
Date:       2014-11-29 1:54:11
Message-ID: 20141129014211.GK24022 () spoyarek ! pnq ! redhat ! com
[Download RAW message or body]


On Wed, Nov 26, 2014 at 02:30:48PM -0500, James Lemke wrote:
> On 11/26/2014 04:40 AM, Will Newton wrote:
> >This looks ok to me, although there are some minor style issues, e.g.:
> >
> >There should be a space after casts.
> >There's a bracket on its own that should be moved onto the line above.
> >A couple of if statements have some leading space that should not be there.
> 
> Thanks for the review.  This version fixes the style issues above.
> Unless anyone has other issues I will commit this version.
> Jim.
> 
> -- 
> Jim Lemke, GNU Tools Sourcerer
> Mentor Graphics / CodeSourcery

> 2014-11-26  James Lemke  <jwlemke@codesourcery.com>
> 
> 	[BZ #17581]
> 	* malloc/hooks.c
> 	(mem2mem_check): Add a terminator to the chain of checking blocks.
> 	(malloc_check_get_size): Use it here.
> 	(mem2chunk_check): Ditto.
> 

Looks OK to me.

Siddhesh

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]