[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-alpha
Subject:    Re: [PATCH 1/2] libio: fmemopen rewrite to POSIX compliance
From:       Adhemerval Zanella <azanella () linux ! vnet ! ibm ! com>
Date:       2014-11-27 17:34:42
Message-ID: 547760B2.2000509 () linux ! vnet ! ibm ! com
[Download RAW message or body]

On 06-11-2014 08:57, Adhemerval Zanella wrote:
> On 05-11-2014 19:12, Joseph Myers wrote:
>> On Wed, 5 Nov 2014, Adhemerval Zanella wrote:
>>
>>> This patch added a new fmemopen version, for glibc 2.20, that aims to be
>> 2.21.
>>
>>> 	* libio/Versions [GLIBC_2.20]: Add new fmemopen symbol.
>> 2.21.
>>
>>> 	* sysdeps/unix/sysv/linux/aarch64/nptl/libc.abilist [GLIBC_2.20]: Add
>>> 	fmemopen.
>>> 	* sysdeps/unix/sysv/linux/alpha/libc.abilist [GLIBC_2.20]: Likewise.
>>> 	* sysdeps/unix/sysv/linux/arm/libc.abilist [GLIBC_2.20]: Likewise.
>>> 	* sysdeps/unix/sysv/linux/i386/libc.abilist [GLIBC_2.20]: Likewise.
>>> 	* sysdeps/unix/sysv/linux/ia64/nptl/libc.abilist [GLIBC_2.20]:
>>> 	Likewise.
>> 2.21.  And those nptl subdirectories no longer exist.
>>
>>> +/* fmemopen() from 2.20 and forward works as defined by POSIX.  It also
>>> +   provides an older symbol, version 2.2.5, that behaves different regarding
>>> +   SEEK_END (libio/oldfmemopen.c).  */
>> 2.21.
>>
>>> +#if SHLIB_COMPAT (libc, GLIBC_2_2, GLIBC_2_20)
>> 2.21 (it's the first version in which the symbol was obsolete, not the 
>> last version in which it was non-obsolete).
>>
> Ouch, I though I had fixed all of these.  Fixed now.  Regarding the fmemopen implementation
> itself, any comments?
>
Ping (with Joseph recommendation applied).

[prev in list] [next in list] [prev in thread] [next in thread]