[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-alpha
Subject:    Re: Accidental checkin?
From:       "H.J. Lu" <hjl.tools () gmail ! com>
Date:       2010-12-14 16:48:24
Message-ID: AANLkTim_Kvx8TP8Cd4nwHdCJQ8osVMRh3WTRLDeS51HS () mail ! gmail ! com
[Download RAW message or body]

On Tue, Dec 14, 2010 at 8:43 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Dec 14, 2010 at 8:39 AM, Andreas Schwab <schwab@redhat.com> wrote:
>> "H.J. Lu" <hjl.tools@gmail.com> writes:
>>
>>> On Tue, Dec 14, 2010 at 7:47 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> On Tue, Dec 14, 2010 at 5:42 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>> Hi,
>>>>>
>>>>> Commit 42acbb92c861e97a6e1293ea853db88342a1bf53:
>>>>>
>>>>> http://sourceware.org/git/?p=glibc.git;a=commit;h=42acbb92c861e97a6e1293ea853db88342a1bf53
>>>>>
>>>>> changed
>>>>>
>>>>> sysdeps/i386/i686/multiarch/strcmp.S
>>>>>
>>>>> without ChangeLog entry.  Is that an accidental checkin?
>>>>>
>>>>
>>>> This change caused:
>>>>
>>>> http://sourceware.org/bugzilla/show_bug.cgi?id=12318
>>>>
>>>
>>> That change has a typo.
>>
>> It is bogus in its entirety.  It uses a call clobbered register around a
>> function call.
>
> That is why my ia32 system crashes at random :-).
>

Shouldn't it be reverted as an obvious fix?

Thanks.

-- 
H.J.

[prev in list] [next in list] [prev in thread] [next in thread]