[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-alpha
Subject:    PATCH: Calling movnti without sfence?
From:       "H.J. Lu" <hjl () lucon ! org>
Date:       2007-11-07 19:10:18
Message-ID: 20071107191018.GA4922 () lucon ! org
[Download RAW message or body]

On Wed, Nov 07, 2007 at 11:55:19AM -0600, rajagopal, dwarak wrote:
> Yes, sfence should be used in the place where you suggested.
> 

Here is a patch.


H.J.
----
2007-11-07  H.J. Lu  <hongjiu.lu@intel.com>

	* sysdeps/x86_64/memset.S: Add sfence after movnti.

--- sysdeps/x86_64/memset.S.sfence	2007-11-02 09:28:05.000000000 -0700
+++ sysdeps/x86_64/memset.S	2007-11-07 08:38:55.000000000 -0800
@@ -128,6 +128,7 @@ L(memset_entry):
 	add	$0x40,%rcx
 	dec	%rax
 	jne	11b
+	sfence
 	jmp	4b
 
 END (memset)
[prev in list] [next in list] [prev in thread] [next in thread]