[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-alpha
Subject:    Re: Broken glibc in CVS for most 64bit targets
From:       Jakub Jelinek <jakub () redhat ! com>
Date:       2006-02-13 22:30:16
Message-ID: 20060213223016.GJ4625 () sunsite ! mff ! cuni ! cz
[Download RAW message or body]

On Mon, Feb 13, 2006 at 02:27:38PM -0800, H. J. Lu wrote:
> Today's glibc in CVS won't build on most 64bit targets due to the nptl
> change:
> 
> 2006-02-12  Ulrich Drepper  <drepper@redhat.com>
> 
>         * allocatestack.c (allocate_stack): Initialize robust_list.
>         * init.c (__pthread_initialize_minimal_internal): Likewise.
>         * descr.h (struct xid_command): Pretty printing.
>         (struct pthread): Use __pthread_list_t or __pthread_slist_t for
>         robust_list.  Adjust macros.
>         * pthread_create.c (start_thread): Adjust robust_list handling.
>         * phtread_mutex_unlock.c: Don't allow unlocking from any thread
>         but the owner for all robust mutex types.
>         * sysdeps/unix/sysv/linux/i386/bits/pthreadtypes.h: Define
>         __pthread_list_t and __pthread_slist_t.  Use them in
> pthread_mutex_t.
>         * sysdeps/pthread/pthread.h: Adjust mutex initializers.
> 
> __pthread_list_t is now used for 64bit targets. But it is only defined
> for x86-64. I saw Jakub fix it on fedora-branch.

Yeah, I posted it to the ml as well:
http://sources.redhat.com/ml/libc-hacker/2006-02/msg00022.html

> Also the ChangeLog
> entry for sysdeps/unix/sysv/linux/x86_64/bits/pthreadtypes.h is
> missing.

True, also noticed that.

	Jakub
[prev in list] [next in list] [prev in thread] [next in thread]