[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    pwm: dwc: Use devm_pwmchip_add()
From:       Linux Kernel Mailing List <linux-kernel () vger ! kernel ! org>
Date:       2023-02-28 17:17:43
Message-ID: git-mailbomb-linux-master-cf70d01a62c712ee715df1f7892b58c77474bcfb () kernel ! org
[Download RAW message or body]

Commit:     cf70d01a62c712ee715df1f7892b58c77474bcfb
Parent:     a357d1493f0c66ce8006dd28c07646d1f891259a
Refname:    refs/heads/master
Web:        https://git.kernel.org/torvalds/c/cf70d01a62c712ee715df1f7892b58c77474bcfb
Author:     Ben Dooks <ben.dooks@sifive.com>
AuthorDate: Fri Dec 23 15:38:15 2022 +0000
Committer:  Thierry Reding <thierry.reding@gmail.com>
CommitDate: Mon Feb 20 12:26:35 2023 +0100

    pwm: dwc: Use devm_pwmchip_add()
    
    Add the PWM chip using devm_pwmchip_add() to avoid having to manually
    remove it. This is useful for subsequent patches adding platform device
    support.
    
    Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
    Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---
 drivers/pwm/pwm-dwc.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
index e9399df702ed4..3bbb26c862c35 100644
--- a/drivers/pwm/pwm-dwc.c
+++ b/drivers/pwm/pwm-dwc.c
@@ -244,7 +244,7 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
 		return -ENOMEM;
 	}
 
-	ret = pwmchip_add(&dwc->chip);
+	ret = devm_pwmchip_add(dev, &dwc->chip);
 	if (ret)
 		return ret;
 
@@ -256,12 +256,8 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
 
 static void dwc_pwm_remove(struct pci_dev *pci)
 {
-	struct dwc_pwm *dwc = pci_get_drvdata(pci);
-
 	pm_runtime_forbid(&pci->dev);
 	pm_runtime_get_noresume(&pci->dev);
-
-	pwmchip_remove(&dwc->chip);
 }
 
 #ifdef CONFIG_PM_SLEEP
[prev in list] [next in list] [prev in thread] [next in thread]