[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    ext4: fix inode tree inconsistency caused by ENOMEM
From:       Linux Kernel Mailing List <linux-kernel () vger ! kernel ! org>
Date:       2023-02-28 17:17:34
Message-ID: git-mailbomb-linux-master-3f5424790d4377839093b68c12b130077a4e4510 () kernel ! org
[Download RAW message or body]

Commit:     3f5424790d4377839093b68c12b130077a4e4510
Parent:     f31173c19901a96bb2ebf6bcfec8a08df7095c91
Refname:    refs/heads/master
Web:        https://git.kernel.org/torvalds/c/3f5424790d4377839093b68c12b130077a4e4510
Author:     zhanchengbin <zhanchengbin1@huawei.com>
AuthorDate: Tue Jan 3 10:28:12 2023 +0800
Committer:  Theodore Ts'o <tytso@mit.edu>
CommitDate: Sat Feb 18 23:58:28 2023 -0500

    ext4: fix inode tree inconsistency caused by ENOMEM
    
    If ENOMEM fails when the extent is splitting, we need to restore the length
    of the split extent.
    In the ext4_split_extent_at function, only in ext4_ext_create_new_leaf will
    it alloc memory and change the shape of the extent tree,even if an ENOMEM
    is returned at this time, the extent tree is still self-consistent, Just
    restore the split extent lens in the function ext4_split_extent_at.
    
    ext4_split_extent_at
     ext4_ext_insert_extent
      ext4_ext_create_new_leaf
       1)ext4_ext_split
         ext4_find_extent
       2)ext4_ext_grow_indepth
         ext4_find_extent
    
    Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Link: https://lore.kernel.org/r/20230103022812.130603-1-zhanchengbin1@huawei.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 fs/ext4/extents.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 9de1c9d1a13d3..3559ea6b07818 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3251,7 +3251,7 @@ static int ext4_split_extent_at(handle_t *handle,
 		ext4_ext_mark_unwritten(ex2);
 
 	err = ext4_ext_insert_extent(handle, inode, ppath, &newex, flags);
-	if (err != -ENOSPC && err != -EDQUOT)
+	if (err != -ENOSPC && err != -EDQUOT && err != -ENOMEM)
 		goto out;
 
 	if (EXT4_EXT_MAY_ZEROOUT & split_flag) {
[prev in list] [next in list] [prev in thread] [next in thread]