[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    ACPI: video: Don't enable fallback path for creating ACPI backlight by default
From:       Linux Kernel Mailing List <linux-kernel () vger ! kernel ! org>
Date:       2022-12-30 18:50:54
Message-ID: git-mailbomb-linux-master-5aa9d943e9b6bf6e6023645cbe7ce7d5ed84baf4 () kernel ! org
[Download RAW message or body]

Commit:     5aa9d943e9b6bf6e6023645cbe7ce7d5ed84baf4
Parent:     c573e240609ff781a0246c0c8c8351abd0475287
Refname:    refs/heads/master
Web:        https://git.kernel.org/torvalds/c/5aa9d943e9b6bf6e6023645cbe7ce7d5ed84baf4
Author:     Mario Limonciello <mario.limonciello@amd.com>
AuthorDate: Thu Dec 8 10:42:07 2022 -0600
Committer:  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
CommitDate: Thu Dec 22 17:26:42 2022 +0100

    ACPI: video: Don't enable fallback path for creating ACPI backlight by default
    
    The ACPI video detection code has a module parameter
    `register_backlight_delay` which is currently configured to 8 seconds.
    This means that if after 8 seconds of booting no native driver has created
    a backlight device then the code will attempt to make an ACPI video
    backlight device.
    
    This was intended as a safety mechanism with the backlight overhaul that
    occurred in kernel 6.1, but as it doesn't appear necesssary set it to be
    disabled by default.
    
    Suggested-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/acpi_video.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index 75dc37affff25..97b711e57bff4 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -70,11 +70,7 @@ module_param(device_id_scheme, bool, 0444);
 static int only_lcd = -1;
 module_param(only_lcd, int, 0444);
 
-/*
- * Display probing is known to take up to 5 seconds, so delay the fallback
- * backlight registration by 5 seconds + 3 seconds for some extra margin.
- */
-static int register_backlight_delay = 8;
+static int register_backlight_delay;
 module_param(register_backlight_delay, int, 0444);
 MODULE_PARM_DESC(register_backlight_delay,
 	"Delay in seconds before doing fallback (non GPU driver triggered) "
[prev in list] [next in list] [prev in thread] [next in thread]