[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    lib/test_cpumask: fix cpu_possible_mask last test
From:       Linux Kernel Mailing List <linux-kernel () vger ! kernel ! org>
Date:       2022-08-28 21:48:21
Message-ID: git-mailbomb-linux-master-fbbc94d8486c6d683650269154c9a7d8897f35d7 () kernel ! org
[Download RAW message or body]

Commit:     fbbc94d8486c6d683650269154c9a7d8897f35d7
Parent:     6afd9db630b037c7f0bc939368216512568de607
Refname:    refs/heads/master
Web:        https://git.kernel.org/torvalds/c/fbbc94d8486c6d683650269154c9a7d8897f35d7
Author:     Sander Vanheule <sander@svanheule.net>
AuthorDate: Tue Aug 23 08:12:20 2022 +0200
Committer:  Yury Norov <yury.norov@gmail.com>
CommitDate: Wed Aug 24 08:35:42 2022 -0700

    lib/test_cpumask: fix cpu_possible_mask last test
    
    Since cpumask_first() on the cpu_possible_mask must return at most
    nr_cpu_ids - 1 for a valid result, cpumask_last() cannot return anything
    larger than this value.  As test_cpumask_weight() also verifies that the
    total weight of cpu_possible_mask must equal nr_cpu_ids, the last bit
    set in this mask must be at nr_cpu_ids - 1.
    
    Fixes: c41e8866c28c ("lib/test: introduce cpumask KUnit test suite")
    Link: https://lore.kernel.org/lkml/346cb279-8e75-24b0-7d12-9803f2b41c73@riseup.net/
    Reported-by: Maíra Canal <mairacanal@riseup.net>
    Signed-off-by: Sander Vanheule <sander@svanheule.net>
    Tested-by: Maíra Canal <mairacanal@riseup.net>
    Reviewed-by: David Gow <davidgow@google.com>
    Acked-by: Yury Norov <yury.norov@gmail.com>
    Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
 lib/test_cpumask.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_cpumask.c b/lib/test_cpumask.c
index 4ebf9f5805f32..4d353614d853e 100644
--- a/lib/test_cpumask.c
+++ b/lib/test_cpumask.c
@@ -73,7 +73,7 @@ static void test_cpumask_first(struct kunit *test)
 static void test_cpumask_last(struct kunit *test)
 {
 	KUNIT_EXPECT_LE(test, nr_cpumask_bits, cpumask_last(&mask_empty));
-	KUNIT_EXPECT_EQ(test, nr_cpumask_bits - 1, cpumask_last(cpu_possible_mask));
+	KUNIT_EXPECT_EQ(test, nr_cpu_ids - 1, cpumask_last(cpu_possible_mask));
 }
 
 static void test_cpumask_next(struct kunit *test)
[prev in list] [next in list] [prev in thread] [next in thread]