[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    selftests: net: devlink_port_split: check devlink returned an element before dereferencing it
From:       Linux Kernel Mailing List <linux-kernel () vger ! kernel ! org>
Date:       2021-06-30 23:50:18
Message-ID: git-mailbomb-linux-master-a118ff661889ecee3ca90f8125bad8fb5bbc07d5 () kernel ! org
[Download RAW message or body]

Commit:     a118ff661889ecee3ca90f8125bad8fb5bbc07d5
Parent:     b856150c8098f12996ee81c3ab2a65adbaeeb3ec
Refname:    refs/heads/master
Web:        https://git.kernel.org/torvalds/c/a118ff661889ecee3ca90f8125bad8fb5bbc07d5
                
Author:     Paolo Pisati <paolo.pisati@canonical.com>
AuthorDate: Mon Jun 28 16:54:24 2021 +0200
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Mon Jun 28 16:14:38 2021 -0700

    selftests: net: devlink_port_split: check devlink returned an element before \
dereferencing it  
    And thus avoid a Python stacktrace:
    
    ~/linux/tools/testing/selftests/net$ ./devlink_port_split.py
    Traceback (most recent call last):
      File "/home/linux/tools/testing/selftests/net/./devlink_port_split.py",
    line 277, in <module> main()
      File "/home/linux/tools/testing/selftests/net/./devlink_port_split.py",
    line 242, in main
        dev = list(devs.keys())[0]
    IndexError: list index out of range
    
    Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 tools/testing/selftests/net/devlink_port_split.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/net/devlink_port_split.py \
b/tools/testing/selftests/net/devlink_port_split.py index \
                834066d465fc1..d162915311fd1 100755
--- a/tools/testing/selftests/net/devlink_port_split.py
+++ b/tools/testing/selftests/net/devlink_port_split.py
@@ -239,6 +239,9 @@ def main(cmdline=None):
         assert stderr == ""
 
         devs = json.loads(stdout)['dev']
+        if len(devs.keys()) == 0:
+            print("no devlink device found")
+            sys.exit(1)
         dev = list(devs.keys())[0]
 
     cmd = "devlink dev show %s" % dev


[prev in list] [next in list] [prev in thread] [next in thread]