[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    Drivers: hv: vmbus: check the creation_status in vmbus_establish_gpadl()
From:       Linux Kernel Mailing List <linux-kernel () vger ! kernel ! org>
Date:       2018-11-30 21:01:26
Message-ID: git-mailbomb-linux-master-eceb05965489784f24bbf4d61ba60e475a983016 () kernel ! org
[Download RAW message or body]

Commit:     eceb05965489784f24bbf4d61ba60e475a983016
Parent:     7bada55ab50697861eee6bb7d60b41e68a961a9c
Refname:    refs/heads/master
Web:        https://git.kernel.org/torvalds/c/eceb05965489784f24bbf4d61ba60e475a983016
Author:     Dexuan Cui <decui@microsoft.com>
AuthorDate: Mon Nov 26 02:29:56 2018 +0000
Committer:  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CommitDate: Mon Nov 26 20:33:56 2018 +0100

    Drivers: hv: vmbus: check the creation_status in vmbus_establish_gpadl()
    
    This is a longstanding issue: if the vmbus upper-layer drivers try to
    consume too many GPADLs, the host may return with an error
    0xC0000044 (STATUS_QUOTA_EXCEEDED), but currently we forget to check
    the creation_status, and hence we can pass an invalid GPADL handle
    into the OPEN_CHANNEL message, and get an error code 0xc0000225 in
    open_info->response.open_result.status, and finally we hang in
    vmbus_open() -> "goto error_free_info" -> vmbus_teardown_gpadl().
    
    With this patch, we can exit gracefully on STATUS_QUOTA_EXCEEDED.
    
    Cc: Stephen Hemminger <sthemmin@microsoft.com>
    Cc: K. Y. Srinivasan <kys@microsoft.com>
    Cc: Haiyang Zhang <haiyangz@microsoft.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Dexuan Cui <decui@microsoft.com>
    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/hv/channel.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index de8193f3b838..fe00b12e4417 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -516,6 +516,14 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer,
 	}
 	wait_for_completion(&msginfo->waitevent);
 
+	if (msginfo->response.gpadl_created.creation_status != 0) {
+		pr_err("Failed to establish GPADL: err = 0x%x\n",
+		       msginfo->response.gpadl_created.creation_status);
+
+		ret = -EDQUOT;
+		goto cleanup;
+	}
+
 	if (channel->rescind) {
 		ret = -ENODEV;
 		goto cleanup;
[prev in list] [next in list] [prev in thread] [next in thread]