[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    bnx2x: Don't log mc removal needlessly
From:       "Linux Kernel Mailing List" <linux-kernel () vger ! kernel ! org>
Date:       2017-06-29 21:34:35
Message-ID: 20170629213435.AE8B2227DD () pdx-korg-gitolite-1 ! ci ! codeaurora ! org
[Download RAW message or body]

Web:        https://git.kernel.org/torvalds/c/d0c32a16235aeacd32c9de6ff90f9219614d7e4e
                
Commit:     d0c32a16235aeacd32c9de6ff90f9219614d7e4e
Parent:     92cc8a5105e1236584e92288595ddbd2149bb6cf
Refname:    refs/heads/master
Author:     Mintz, Yuval <Yuval.Mintz@cavium.com>
AuthorDate: Sat Jun 24 15:37:00 2017 +0300
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Sun Jun 25 11:36:56 2017 -0400

    bnx2x: Don't log mc removal needlessly
    
    When mc configuration changes bnx2x_config_mcast() can return 0 for
    success, negative for failure and positive for benign reason preventing
    its immediate work, e.g., when the command awaits the completion of
    a previously sent command.
    
    When removing all configured macs on a 578xx adapter, if a positive
    value would be returned driver would errneously log it as an error.
    
    Fixes: c7b7b483ccc9 ("bnx2x: Don't flush multicast MACs")
    Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c \
b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index a851f95c307a..349a46593abf \
                100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -12729,7 +12729,7 @@ static int bnx2x_set_mc_list(struct bnx2x *bp)
 	} else {
 		/* If no mc addresses are required, flush the configuration */
 		rc = bnx2x_config_mcast(bp, &rparam, BNX2X_MCAST_CMD_DEL);
-		if (rc)
+		if (rc < 0)
 			BNX2X_ERR("Failed to clear multicast configuration %d\n",
 				  rc);
 	}
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]