[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    ata: sata_mv:- Handle return value of devm_ioremap.
From:       "Linux Kernel Mailing List" <linux-kernel () vger ! kernel ! org>
Date:       2017-01-31 21:57:06
Message-ID: 20170131215706.AA9B7660FE6 () gitolite ! kernel ! org
[Download RAW message or body]

Web:        https://git.kernel.org/torvalds/c/064c3db9c564cc5be514ac21fb4aa26cc33db746
Commit:     064c3db9c564cc5be514ac21fb4aa26cc33db746
Parent:     2dae99558e86894e9e5dbf097477baaa5eb70134
Refname:    refs/heads/master
Author:     Arvind Yadav <arvind.yadav.cs@gmail.com>
AuthorDate: Mon Dec 12 23:13:27 2016 +0530
Committer:  Tejun Heo <tj@kernel.org>
CommitDate: Fri Jan 6 15:45:32 2017 -0500

    ata: sata_mv:- Handle return value of devm_ioremap.
    
    Here, If devm_ioremap will fail. It will return NULL.
    Then hpriv->base = NULL - 0x20000; Kernel can run into
    a NULL-pointer dereference. This error check will avoid
    NULL pointer dereference.
    
    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    Signed-off-by: Tejun Heo <tj@kernel.org>
    Cc: stable@vger.kernel.org
---
 drivers/ata/sata_mv.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 823e938..2f32782 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -4132,6 +4132,9 @@ static int mv_platform_probe(struct platform_device *pdev)
 	host->iomap = NULL;
 	hpriv->base = devm_ioremap(&pdev->dev, res->start,
 				   resource_size(res));
+	if (!hpriv->base)
+		return -ENOMEM;
+
 	hpriv->base -= SATAHC0_REG_BASE;
 
 	hpriv->clk = clk_get(&pdev->dev, NULL);
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]