[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    IB/rdmavt: Fix send scheduling
From:       "Linux Kernel Mailing List" <linux-kernel () vger ! kernel ! org>
Date:       2016-04-30 0:48:59
Message-ID: 20160430004859.26CE2660F5C () gitolite ! kernel ! org
[Download RAW message or body]

Web:        https://git.kernel.org/torvalds/c/e6d2e0176e1f3c1e1534851b66c0b972f03ff069
Commit:     e6d2e0176e1f3c1e1534851b66c0b972f03ff069
Parent:     849e3e9398608c26a7c54bf9fbf3288f7ced6bfb
Refname:    refs/heads/master
Author:     Jubin John <jubin.john@intel.com>
AuthorDate: Tue Apr 12 10:47:00 2016 -0700
Committer:  Doug Ledford <dledford@redhat.com>
CommitDate: Thu Apr 28 12:00:39 2016 -0400

    IB/rdmavt: Fix send scheduling
    
    call_send is used to determine whether to send immediately or schedule
    a send for later. The current logic in rdmavt is inverted and has a
    negative impact on the latency of the hfi1 and qib drivers. Fix this
    regression by correctly calling send immediately when call_send is set.
    
    Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
    Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
    Signed-off-by: Jubin John <jubin.john@intel.com>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
---
 drivers/infiniband/sw/rdmavt/qp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/sw/rdmavt/qp.c b/drivers/infiniband/sw/rdmavt/qp.c
index bd82a69..a9e3bcc 100644
--- a/drivers/infiniband/sw/rdmavt/qp.c
+++ b/drivers/infiniband/sw/rdmavt/qp.c
@@ -1637,9 +1637,9 @@ bail:
 	spin_unlock_irqrestore(&qp->s_hlock, flags);
 	if (nreq) {
 		if (call_send)
-			rdi->driver_f.schedule_send_no_lock(qp);
-		else
 			rdi->driver_f.do_send(qp);
+		else
+			rdi->driver_f.schedule_send_no_lock(qp);
 	}
 	return err;
 }
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]