[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    6pack: Fix use after free in sixpack_close().
From:       "Linux Kernel Mailing List" <linux-kernel () vger ! kernel ! org>
Date:       2015-12-31 22:51:33
Message-ID: 20151231225133.A96FF661289 () gitolite ! kernel ! org
[Download RAW message or body]

Web:        https://git.kernel.org/torvalds/c/acf673a3187edf72068ee2f92f4dc47d66baed47
Commit:     acf673a3187edf72068ee2f92f4dc47d66baed47
Parent:     6e3cd5fa65318f35ec9c9f61bc5cdb55d4783cb9
Refname:    refs/heads/master
Author:     David Miller <davem@davemloft.net>
AuthorDate: Thu Dec 17 16:05:32 2015 -0500
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Fri Dec 18 15:57:33 2015 -0500

    6pack: Fix use after free in sixpack_close().
    
    Need to do the unregister_device() after all references to the driver
    private have been done.
    
    Also we need to use del_timer_sync() for the timers so that we don't
    have any asynchronous references after the unregister.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/hamradio/6pack.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c
index 7c4a415..9f0b1c3 100644
--- a/drivers/net/hamradio/6pack.c
+++ b/drivers/net/hamradio/6pack.c
@@ -683,14 +683,14 @@ static void sixpack_close(struct tty_struct *tty)
 	if (!atomic_dec_and_test(&sp->refcnt))
 		down(&sp->dead_sem);
 
-	unregister_netdev(sp->dev);
-
-	del_timer(&sp->tx_t);
-	del_timer(&sp->resync_t);
+	del_timer_sync(&sp->tx_t);
+	del_timer_sync(&sp->resync_t);
 
 	/* Free all 6pack frame buffers. */
 	kfree(sp->rbuff);
 	kfree(sp->xbuff);
+
+	unregister_netdev(sp->dev);
 }
 
 /* Perform I/O control on an active 6pack channel. */
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]