[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    drm/exynos: dsi: use IS_ERR() to check devm_ioremap_resource() results
From:       "Linux Kernel Mailing List" <linux-kernel () vger ! kernel ! org>
Date:       2014-04-30 2:53:50
Message-ID: 20140430025350.357EB660EA2 () gitolite ! kernel ! org
[Download RAW message or body]

Gitweb:     http://git.kernel.org/linus/;a=commit;h=293d3f6a70704691c3539bc3630ba1acbabc5c43
Commit:     293d3f6a70704691c3539bc3630ba1acbabc5c43
Parent:     e2a75c446e38ddf32ccdeb6e8cf2baa61fd8510f
Author:     Jingoo Han <jg1.han@samsung.com>
AuthorDate: Thu Apr 17 19:08:40 2014 +0900
Committer:  Dave Airlie <airlied@redhat.com>
CommitDate: Wed Apr 30 09:48:50 2014 +1000

    drm/exynos: dsi: use IS_ERR() to check devm_ioremap_resource() results
    
    devm_ioremap_resource() returns an error pointer, not NULL. Thus,
    the result should be checked with IS_ERR().
    
    Signed-off-by: Jingoo Han <jg1.han@samsung.com>
    Signed-off-by: Inki Dae <inki.dae@samsung.com>
    Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/exynos/exynos_drm_dsi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index eb73e3b..4ac4381 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1426,9 +1426,9 @@ static int exynos_dsi_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	dsi->reg_base = devm_ioremap_resource(&pdev->dev, res);
-	if (!dsi->reg_base) {
+	if (IS_ERR(dsi->reg_base)) {
 		dev_err(&pdev->dev, "failed to remap io region\n");
-		return -EADDRNOTAVAIL;
+		return PTR_ERR(dsi->reg_base);
 	}
 
 	dsi->phy = devm_phy_get(&pdev->dev, "dsim");
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]