[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    dm cache: move hook_info into common portion of per_bio_data structure
From:       "Linux Kernel Mailing List" <linux-kernel () vger ! kernel ! org>
Date:       2014-02-28 22:55:16
Message-ID: 20140228225516.90451660CDA () gitolite ! kernel ! org
[Download RAW message or body]

Gitweb:     http://git.kernel.org/linus/;a=commit;h=c6eda5e81c4fcc77185117255c7419eda771f67f
Commit:     c6eda5e81c4fcc77185117255c7419eda771f67f
Parent:     6d0abeca3242a88cab8232e4acd7e2bf088f3bc2
Author:     Mike Snitzer <snitzer@redhat.com>
AuthorDate: Fri Jan 31 14:11:54 2014 -0500
Committer:  Mike Snitzer <snitzer@redhat.com>
CommitDate: Mon Feb 17 11:00:05 2014 -0500

    dm cache: move hook_info into common portion of per_bio_data structure
    
    Commit c9d28d5d ("dm cache: promotion optimisation for writes")
    incorrectly placed the 'hook_info' member in the writethrough-only
    portion of the per_bio_data structure.
    
    Given that the overwrite optimization may be used for writeback the
    'hook_info' member must be placed above the 'cache' member of the
    per_bio_data structure.  Any members above 'cache' are available from
    both writeback and writethrough modes' per_bio_data structure.
    
    Signed-off-by: Mike Snitzer <snitzer@redhat.com>
    Acked-by: Joe Thornber <ejt@redhat.com>
    Cc: stable@vger.kernel.org # 3.13+
---
 drivers/md/dm-cache-target.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index ffd472e..14256b7 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -289,6 +289,7 @@ struct per_bio_data {
 	bool tick:1;
 	unsigned req_nr:2;
 	struct dm_deferred_entry *all_io_entry;
+	struct dm_hook_info hook_info;
 
 	/*
 	 * writethrough fields.  These MUST remain at the end of this
@@ -297,7 +298,6 @@ struct per_bio_data {
 	 */
 	struct cache *cache;
 	dm_cblock_t cblock;
-	struct dm_hook_info hook_info;
 	struct dm_bio_details bio_details;
 };
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]