[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    arch/arm/mach-omap2/dma.c: Convert IS_ERR result to PTR_ERR
From:       Linux Kernel Mailing List <linux-kernel () vger ! kernel ! org>
Date:       2011-01-31 22:59:50
Message-ID: 201101312259.p0VMxoW6004481 () hera ! kernel ! org
[Download RAW message or body]

Gitweb:     http://git.kernel.org/linus/0e6d8cad448bde3d846961bb43db15daae94562e
Commit:     0e6d8cad448bde3d846961bb43db15daae94562e
Parent:     afb7d7099e27f30caf69b3ce80a4cb86612a0b87
Author:     Julia Lawall <julia@diku.dk>
AuthorDate: Thu Jan 27 15:49:06 2011 +0000
Committer:  Tony Lindgren <tony@atomide.com>
CommitDate: Thu Jan 27 16:25:35 2011 -0800

    arch/arm/mach-omap2/dma.c: Convert IS_ERR result to PTR_ERR
    
    This code elsewhere returns a negative constant to an indicate an error,
    while IS_ERR returns the result of a >= operation.
    
    The semantic patch that fixes this problem is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @@
    expression x;
    @@
    
     if (...) { ...
    - return IS_ERR(x);
    + return PTR_ERR(x);
    }
    // </smpl>
    
    Signed-off-by: Julia Lawall <julia@diku.dk>
    Acked-by: Jarkko Nikula <jhnikula@gmail.com>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
index d2f15f5..34922b2 100644
--- a/arch/arm/mach-omap2/dma.c
+++ b/arch/arm/mach-omap2/dma.c
@@ -264,7 +264,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused)
 	if (IS_ERR(od)) {
 		pr_err("%s: Cant build omap_device for %s:%s.\n",
 			__func__, name, oh->name);
-		return IS_ERR(od);
+		return PTR_ERR(od);
 	}
 
 	mem = platform_get_resource(&od->pdev, IORESOURCE_MEM, 0);
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]