[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    can: pch_can: fix sparse warning
From:       Linux Kernel Mailing List <linux-kernel () vger ! kernel ! org>
Date:       2010-10-31 1:59:07
Message-ID: 201010310159.o9V1x7ne026884 () hera ! kernel ! org
[Download RAW message or body]

Gitweb:     http://git.kernel.org/linus/526de53cf78d325351904eefb9624f933924df75
Commit:     526de53cf78d325351904eefb9624f933924df75
Parent:     c117e4a2bb49116b0b51df06bbabe638d28dfae7
Author:     Marc Kleine-Budde <mkl@pengutronix.de>
AuthorDate: Sat Oct 30 16:27:48 2010 -0700
Committer:  David S. Miller <davem@davemloft.net>
CommitDate: Sat Oct 30 16:27:48 2010 -0700

    can: pch_can: fix sparse warning
    
    This patch fixes the following sparse warning:
    
    drivers/net/can/pch_can.c:231:26: warning: incorrect type in argument 1 (different address spaces)
    drivers/net/can/pch_can.c:231:26:    expected unsigned int [usertype] *addr
    drivers/net/can/pch_can.c:231:26:    got unsigned int [noderef] <asn:2>*<noident>
    
    Let pch_can_bit_{set,clear} first parameter be a void __iomem pointer.
    
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/can/pch_can.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
index 55ec324..c63209f 100644
--- a/drivers/net/can/pch_can.c
+++ b/drivers/net/can/pch_can.c
@@ -213,12 +213,12 @@ static DEFINE_PCI_DEVICE_TABLE(pch_pci_tbl) = {
 };
 MODULE_DEVICE_TABLE(pci, pch_pci_tbl);
 
-static inline void pch_can_bit_set(u32 *addr, u32 mask)
+static inline void pch_can_bit_set(void __iomem *addr, u32 mask)
 {
 	iowrite32(ioread32(addr) | mask, addr);
 }
 
-static inline void pch_can_bit_clear(u32 *addr, u32 mask)
+static inline void pch_can_bit_clear(void __iomem *addr, u32 mask)
 {
 	iowrite32(ioread32(addr) & ~mask, addr);
 }
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic