[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    trace_stack: Fix seqfile memory leak
From:       Linux Kernel Mailing List <linux-kernel () vger ! kernel ! org>
Date:       2009-07-31 0:00:02
Message-ID: 200907310000.n6V002u8025000 () hera ! kernel ! org
[Download RAW message or body]

Gitweb:     http://git.kernel.org/linus/d8cc1ab793993c886c62abf77c93287df33ffd8b
Commit:     d8cc1ab793993c886c62abf77c93287df33ffd8b
Parent:     e5d490b252423605a77c54b2e35b10ea663763df
Author:     Li Zefan <lizf@cn.fujitsu.com>
AuthorDate: Thu Jul 23 11:28:40 2009 +0800
Committer:  Steven Rostedt <rostedt@goodmis.org>
CommitDate: Thu Jul 23 09:52:09 2009 -0400

    trace_stack: Fix seqfile memory leak
    
    Every time we cat stack_trace, we leak memory allocated by seq_open().
    
    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    LKML-Reference: <4A67D8E8.3020500@cn.fujitsu.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/trace_stack.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c
index e644af9..6a2a9d4 100644
--- a/kernel/trace/trace_stack.c
+++ b/kernel/trace/trace_stack.c
@@ -301,17 +301,14 @@ static const struct seq_operations stack_trace_seq_ops = {
 
 static int stack_trace_open(struct inode *inode, struct file *file)
 {
-	int ret;
-
-	ret = seq_open(file, &stack_trace_seq_ops);
-
-	return ret;
+	return seq_open(file, &stack_trace_seq_ops);
 }
 
 static const struct file_operations stack_trace_fops = {
 	.open		= stack_trace_open,
 	.read		= seq_read,
 	.llseek		= seq_lseek,
+	.release	= seq_release,
 };
 
 int
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]