[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    genirq: __irq_set_trigger: change pr_warning to pr_debug
From:       Linux Kernel Mailing List <linux-kernel () vger ! kernel ! org>
Date:       2008-11-30 22:00:37
Message-ID: 200811302200.mAUM0b9Z003955 () hera ! kernel ! org
[Download RAW message or body]

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3ff68a6a106c362a6811d3e51bced58e6fc87de7
Commit:     3ff68a6a106c362a6811d3e51bced58e6fc87de7
Parent:     f131e2436ddbac2527bb2d6297a823aae4b024f8
Author:     Mark Nelson <markn@au1.ibm.com>
AuthorDate: Thu Nov 13 21:37:41 2008 +1100
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu Nov 13 11:59:48 2008 +0100

    genirq: __irq_set_trigger: change pr_warning to pr_debug
    
    Commit 0c5d1eb77a8be917b638344a22afe1398236482b (genirq: record trigger
    type) caused powerpc platforms that had no set_type() function in their
    struct irq_chip to spew out warnings about "No set_type function for
    IRQ...". This warning isn't necessarily justified though because the
    generic powerpc platform code calls set_irq_type() (which in turn calls
    __irq_set_trigger) with information from the device tree to establish
    the interrupt mappings, regardless of whether the PIC can actually set
    a type.
    
    A platform's irq_chip might not have a set_type function for a variety
    of reasons, for example: the platform may have the type essentially
    hard-coded, or as in the case for Cell interrupts are just messages
    past around that have no real concept of type, or the platform
    could even have a virtual PIC as on the PS3.
    
    Signed-off-by: Mark Nelson <markn@au1.ibm.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/irq/manage.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 4358612..801addd 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -365,7 +365,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq,
 		 * IRQF_TRIGGER_* but the PIC does not support multiple
 		 * flow-types?
 		 */
-		pr_warning("No set_type function for IRQ %d (%s)\n", irq,
+		pr_debug("No set_type function for IRQ %d (%s)\n", irq,
 				chip ? (chip->name ? : "unknown") : "unknown");
 		return 0;
 	}
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]