[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    rtl8180: fix wrong parameter in grf5101_rf_set_channel
From:       Linux Kernel Mailing List <linux-kernel () vger ! kernel ! org>
Date:       2008-05-30 14:59:50
Message-ID: 200805301459.m4UExort026664 () hera ! kernel ! org
[Download RAW message or body]

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=bc1b1fb2753873314ad1bf56bc7d5b8dd447cd2a
Commit:     bc1b1fb2753873314ad1bf56bc7d5b8dd447cd2a
Parent:     0a0ab41e833c8184c6d4ab663f137d5bbd50e049
Author:     Andrea Merello <andrea.merello@gmail.com>
AuthorDate: Sat May 10 13:34:16 2008 +0200
Committer:  John W. Linville <linville@tuxdriver.com>
CommitDate: Wed May 28 16:43:40 2008 -0400

    rtl8180: fix wrong parameter in grf5101_rf_set_channel
    
    The grf5101 RF code needs to invoke grf5101_write_phy_antenna every time the
    channel is being switch.
    
    This should be done passing the channel number to that function.
    Incorrectly we were passing the same value that is written on the
    channel RF register.
    This may cause problems when operating on ch 14.
    
    This patch fixes it.
    
    Thanks to Alessandro Di Marco who found this issue!
    
    Signed-off-by: Andrea Merello <andreamrl@tiscali.it>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
 drivers/net/wireless/rtl8180_grf5101.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/rtl8180_grf5101.c b/drivers/net/wireless/rtl8180_grf5101.c
index 5d47935..947ee55 100644
--- a/drivers/net/wireless/rtl8180_grf5101.c
+++ b/drivers/net/wireless/rtl8180_grf5101.c
@@ -88,7 +88,7 @@ static void grf5101_rf_set_channel(struct ieee80211_hw *dev,
 	write_grf5101(dev, 0x0B, chan);
 	write_grf5101(dev, 0x07, 0x1000);
 
-	grf5101_write_phy_antenna(dev, chan);
+	grf5101_write_phy_antenna(dev, channel);
 }
 
 static void grf5101_rf_stop(struct ieee80211_hw *dev)
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]