[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH 06/16] refs: refactor `resolve_gitlink_ref()` to accept a repository
From:       Junio C Hamano <gitster () pobox ! com>
Date:       2024-05-16 18:45:38
Message-ID: xmqqttixppd9.fsf () gitster ! g
[Download RAW message or body]

Patrick Steinhardt <ps@pks.im> writes:

> diff --git a/refs.c b/refs.c
> index 86008ce7b4..40e241216e 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -1943,13 +1943,14 @@ int ref_store_create(struct ref_store *refs, int flags, struct strbuf *err)
>  	return refs->be->create(refs, flags, err);
>  }
>  
> -int resolve_gitlink_ref(const char *submodule, const char *refname,
> -			struct object_id *oid)
> +int repo_resolve_gitlink_ref(struct repository *r,
> +			     const char *submodule, const char *refname,
> +			     struct object_id *oid)
>  {
>  	struct ref_store *refs;
>  	int flags;
>  
> -	refs = repo_get_submodule_ref_store(the_repository, submodule);
> +	refs = repo_get_submodule_ref_store(r, submodule);
>  	if (!refs)
>  		return -1;

OK.  Looking good.

[prev in list] [next in list] [prev in thread] [next in thread]