[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] tests: modernize the test script t0010-racy-git.sh
From:       Eric Sunshine <sunshine () sunshineco ! com>
Date:       2024-02-29 18:11:46
Message-ID: CAPig+cS5L=i2dYJnc+w5F-k0nSpOjdpqyk6T0gL7i0c01A40nQ () mail ! gmail ! com
[Download RAW message or body]

On Thu, Feb 29, 2024 at 7:24 AM Aryan Gupta via GitGitGadget
<gitgitgadget@gmail.com> wrote:
> From: aryangupta701 <garyan447@gmail.com>

The name in the "From:" header should match the name in the
"Signed-off-by:" trailer.

> Modernize the formatting of the test script to align with current
> standards and improve its overall readability.

The aim of this patch makes sense, but the implementation isn't quite correct.

> Signed-off-by: Aryan Gupta <garyan447@gmail.com>
> ---
> diff --git a/t/t0010-racy-git.sh b/t/t0010-racy-git.sh> @@ -16,19 +16,18 @@ do
>         files=$(git diff-files -p)
> -       test_expect_success \
> -       "Racy GIT trial #$trial part A" \
> -       'test "" != "$files"'
> +       test_expect_success 'Racy git trial #$trial part A' '
> +               test "" != "$files"
> +       '

The variable `trial` takes on values 0-4, and that value is meant to
appear in the test title as the script runs:

    Racy GIT trial #0 part A
    Racy GIT trial #0 part B
    Racy GIT trial #1 part A
    Racy GIT trial #1 part B
    ...

However, by changing the title from a double-quote string to a
single-quote string, you inhibit interpolation of the `trial` variable
into the title, hence the test titles instead show up as:

    Racy GIT trial #$trial part A
    Racy GIT trial #$trial part B
    Racy GIT trial #$trial part A
    Racy GIT trial #$trial part B

which is undesirable.

So, the title should continue using double-quotes, and not be changed
to single-quotes.

The other change, which fixes the style of the test's body, appears correct.

[prev in list] [next in list] [prev in thread] [next in thread]