[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: Supporting `git add -a <exclude submodules>`
From:       Junio C Hamano <gitster () pobox ! com>
Date:       2023-09-28 18:24:08
Message-ID: xmqqfs2yjgvr.fsf () gitster ! g
[Download RAW message or body]

Junio C Hamano <gitster@pobox.com> writes:

> By the way, I am surprised that "diff.ignoreSubmodules=all" is
> abused by anybody that way.  It depends on the implementation detail
> that we internally use the diff machinery to find which paths are
> not modified, and I would even say it is a BUG that "commit -a" pays
> attention to the configuration variable that way.  I would recommend
> strongly to stay away from that approach or your tools will get
> broken when the bug gets fixed.

Sorry, but I take this part back.  This is an explicitly documented
feature of the variable, so users and scripts alike should be able
to depend on.  It still feels like a layering violation, but it is
too late to "fix" it now.

[prev in list] [next in list] [prev in thread] [next in thread]