[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH v2 3/9] send-email docs: de-duplicate configuration sections
From:       Matheus Tavares <matheus.bernardino () usp ! br>
Date:       2022-07-30 13:45:58
Message-ID: CAHd-oW4ZdGxOE4djUwDvt1zVZ2A-FC39FLi=k_7pREAN8AbyYQ () mail ! gmail ! com
[Download RAW message or body]

On Fri, Jul 29, 2022 at 5:26 AM =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason
<avarab@gmail.com> wrote:
>
> De-duplicate the discussion of "send-email" configuration, such that
> the "git-config(1)" manual page becomes the source of truth, and
> "git-send-email(1)" includes the relevant part.
>
> Most commands that suffered from such duplication had diverging text
> discussing the same variables, but in this case some config was also
> only discussed in one or the other.
>
> This is mostly a move-only change, the exception is a minor rewording
> of changing wording like "see above" to "see linkgit:git-config[1]",
> as well as a clarification about the big section of command-line
> option tweaking config being discussed in git-send-email(1)'s main
> docs.

Makes sense. And this is easy to review with --color-moved.

> Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason <avarab@gmail.com>
> ---
>  Documentation/config/sendemail.txt | 40 +++++++++++++++++++++++++++---
>  Documentation/git-send-email.txt   | 36 ++-------------------------
>  2 files changed, 39 insertions(+), 37 deletions(-)
>
> diff --git a/Documentation/config/sendemail.txt b/Documentation/config/se=
ndemail.txt
> index 50baa5d6bfb..51da7088a84 100644
> --- a/Documentation/config/sendemail.txt
> +++ b/Documentation/config/sendemail.txt
> [...]
>  sendemail.annotate::
>  sendemail.bcc::
>  sendemail.cc::
>  sendemail.ccCmd::
>  sendemail.chainReplyTo::
> -sendemail.confirm::
>  sendemail.envelopeSender::
>  sendemail.from::
> -sendemail.multiEdit::
>  sendemail.signedoffbycc::
>  sendemail.smtpPass::
>  sendemail.suppresscc::
> @@ -44,7 +76,9 @@ sendemail.thread::
>  sendemail.transferEncoding::
>  sendemail.validate::
>  sendemail.xmailer::
> -       See linkgit:git-send-email[1] for description.
> +       These configuration variables all provide a default for
> +       linkgit:git-send-email[1] command-line options. See its
> +       documentation for details.

Ok, I looked one by one and these are all indeed mentioned in the
git-send-email(1) cli option documentation.

The rest looks good too.
[prev in list] [next in list] [prev in thread] [next in thread]