[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH v2 1/2] sparse-checkout: custom tab completion tests
From:       Elijah Newren <newren () gmail ! com>
Date:       2021-12-31 22:25:45
Message-ID: CABPp-BGKtggHwXF-Xo6ryKCXNq9mgWDHiKz6VfCvrdKxvf0Uug () mail ! gmail ! com
[Download RAW message or body]

On Fri, Dec 31, 2021 at 2:21 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Elijah Newren <newren@gmail.com> writes:
>
> > Second, and this item is unrelated to your series but your comment
> > made me realize it....sparse-checkout unfortunately ignores prefix and
> > creates a bad .git/info/sparse-checkout file.  For example:
> > ...
> > I think the loss of the current working directory will be fixed by the
> > en/keep-cwd directory (currently in next and marked for merging to
> > master), but the fact that the wrong paths end up in the
> > sparse-checkout file is unfortunate.  It basically means that the
> > `set` and `add` subcommands of `sparse-checkout` can only be safely
> > run from the toplevel directory.
>
> You made it sound as if this is a fundamental limitation, but it
> sounds more like a bug that needs to be fixed (outside the
> completion series, of course) to me.

Oh, sorry, I didn't mean to imply that.  I meant the same thing you
say here: it's another bug we need to fix, in a separate series.
[prev in list] [next in list] [prev in thread] [next in thread]