[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH v5 06/18] diff tests: test that "mode" is passed when sorting
From:       Junio C Hamano <gitster () pobox ! com>
Date:       2021-03-31 23:07:37
Message-ID: xmqq5z166hxi.fsf () gitster ! g
[Download RAW message or body]

=C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason  <avarab@gmail.com> writes:

> Piggy-back on the recently added fsck tests for mode comparisons in
> mktree and assert that diff-tree also does the right thing in this
> implausible scenario.

The same comment applies.  Just testing the order of "foo" (blob),
"foo." (blob), "foo/" (tree), and "foo0" (blob) in two comparisons
would be a more realistic test that has more practical value.

[prev in list] [next in list] [prev in thread] [next in thread]