[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH v5 3/3] ref-filter: add support for %(contents:size)
From:       Jeff King <peff () peff ! net>
Date:       2020-07-31 20:40:57
Message-ID: 20200731204057.GA1440890 () coredump ! intra ! peff ! net
[Download RAW message or body]

On Fri, Jul 31, 2020 at 01:30:19PM -0700, Junio C Hamano wrote:

> > Yeah, I copied a suggestion from Junio in the last iteration without
> > properly checking it. Sorry about that and thanks for spotting and
> > fixing it.
> 
> I probably should stop giving "perhaps along the lines of this"
> suggestion too lightly and/or when I do not have enough time to
> apply and test myself.  Sorry for the gotcha.

I dunno. I appreciate getting them, especially in patch form. It's often
a more precise description than hand-wavy English, and being a patch
makes it easy to apply into my tree as a starting point. The real trick
is that the receiver needs to know enough to distrust the suggestion and
take ownership of it. Maybe you just need a bigger disclaimer. ;)

(Only half-joking; I do try to say "not tested" or "not even compiled"
when that is the case in stuff I sent out, but I'm sure I'm not
consistent).

-Peff
[prev in list] [next in list] [prev in thread] [next in thread]