[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH 3/5] commit: move 'unregister_shallow' to 'shallow.h'
From:       Taylor Blau <me () ttaylorr ! com>
Date:       2020-04-30 19:29:31
Message-ID: 20200430192931.GB6280 () syl ! local
[Download RAW message or body]

On Wed, Apr 29, 2020 at 08:13:50PM -0700, Jonathan Nieder wrote:
> Taylor Blau wrote:
>
> > In the last commit, we introduced a header for the functions defined in
> > 'shallow.c'. There is one remaining shallow-related function in
> > commit.c which should be moved, too. This patch moves that function.
> >
> > Signed-off-by: Taylor Blau <me@ttaylorr.com>
> > ---
> >  commit.c  | 13 -------------
> >  shallow.c | 13 +++++++++++++
> >  shallow.h |  1 +
> >  3 files changed, 14 insertions(+), 13 deletions(-)
>
> Yes, an obviously good thing to do.
>
> Perhaps could be squashed with patch 1 (but also see my review of that
> one).

Do you mean patch 2/5? If so, I think that it probably makes more sense
to go there than in the first patch.

(I originally thought that it would be useful for people reading the
diff to have this change broken out into its own patch, but I think that
it's more juggling to do in terms of figuring out which headers to
include than is worth.)

> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Should this take a "struct repository" parameter?

Probably, but I'd rather leave this series to be just focused on moving
this code around while being minimally invasive.

Thanks,
Taylor
[prev in list] [next in list] [prev in thread] [next in thread]