[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH v6 2/2] builtin/rebase.c: Remove pointless message
From:       Ben <ben () wijen ! net>
Date:       2019-08-31 7:17:18
Message-ID: d5a70a17-9b4c-f060-5b4c-1e0bdb594390 () wijen ! net
[Download RAW message or body]

Hi Junio,

On 30-08-2019 22:16, Junio C Hamano wrote:
> Ben Wijen <ben@wijen.net> writes:
> 
>> -			struct object_id head_oid;
>> -			if (get_oid("HEAD", &head_oid)) {
>> -				ret = error(_("could not determine HEAD revision"));
> 
> I think we saw die() in the previous one.  This patch would not
> apply on top of the result of applying 1/2.

Yes, my fault, sorry about that...

> 
> I'll tentatively queue this instead on top of the corrected 1/2.

Your patch is indeed correct.

Thank you!

> 
> Thanks.
> 
[prev in list] [next in list] [prev in thread] [next in thread]