[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] t5319: don't trip over a user name with whitespace
From:       Jeff King <peff () peff ! net>
Date:       2019-06-30 22:25:37
Message-ID: 20190630222537.GA21696 () sigill ! intra ! peff ! net
[Download RAW message or body]

On Sun, Jun 30, 2019 at 10:59:34PM +0200, Johannes Sixt wrote:

> Am 30.06.19 um 21:48 schrieb Eric Sunshine:
> > On Sun, Jun 30, 2019 at 2:57 PM Johannes Sixt <j6t@kdbg.org> wrote:
> > > diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh
> > > @@ -443,7 +443,7 @@ test_expect_success 'repack with minimum size does not \
> > >                 alter existing packs' '
> > > -               MINSIZE=$(ls -l .git/objects/pack/*pack | awk "{print \$5;}" | \
> > > sort -n | head -n 1) && +               MINSIZE=$(stat -c %s \
> > > .git/objects/pack/*pack | sort -n | head -n 1) &&
> > 
> > Unfortunately, this is not portable. While "stat -c %s" works on Linux
> > and MSYS2, neither that option nor the format directive are recognized
> > on BSD-like platforms (I tested Mac OS and FreeBSD), which instead
> > need "stat -f %z".
> 
> Ouch! I did notice that stat(1) is not in POSIX, but hoped that it was
> sufficiently portable. I need a new idea...

If we are OK relying on rudimentary perl[1], then:

  perl -le "print((stat)[7]) for @ARGV"

works. If you want it more readable, then maybe:

  perl -MFile::stat -le "print stat(\$_)->size for @ARGV"

Both of those should work with even antique perl versions.

-Peff

[1] I'd also be fine with implementing a test-tool helper in C that
    behaves like stat(1). Or we could punt on that until somebody feels
    like trying to eradicate perl (because this is far from the first
    perl one-liner in the test suite).


[prev in list] [next in list] [prev in thread] [next in thread]