[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: What's cooking in git.git (Jun 2019, #06; Wed, 26)
From:       Phillip Wood <phillip.wood123 () gmail ! com>
Date:       2019-06-29 14:08:16
Message-ID: 4f69c62f-f38b-7630-cd8a-ec152a8b6ad0 () gmail ! com
[Download RAW message or body]



On 28/06/2019 20:11, Thomas Gummerer wrote:
> On 06/26, Junio C Hamano wrote:
>> * ra/cherry-pick-revert-skip (2019-06-24) 6 commits
>>   - cherry-pick/revert: advise using --skip
>>   - cherry-pick/revert: add --skip option
>>   - sequencer: use argv_array in reset_merge
>>   - sequencer: rename reset_for_rollback to reset_merge
>>   - sequencer: add advice for revert
>>   - advice: add sequencerInUse config variable
>>
>>   "git cherry-pick/revert" learned a new "--skip" action.
>>
>>   Is this one ready for 'next'?
> 
> Yes, I believe this is ready for 'next'.  I had a look at the latest
> round, and only had a minor comment on the organization of the patch
> series that is probably not worth a re-roll.
> 
> I also added Phillip to Cc, as he's been heavily involved in reviewing
> this series, in case he has any more comments.

Thanks Thomas. I've just posted a comment [1] about a confusing commit 
message and combining two patches but I'm not sure if it's worth a 
re-roll or not. The implementation looks fine to me

Best Wishes

Phillip

[1] 
https://public-inbox.org/git/5ae3461e-7c83-2eeb-552c-ffe838bb03b6@gmail.com/T/#u
[prev in list] [next in list] [prev in thread] [next in thread]