[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: git-gui: unstaged changes windowpane resets after unstaging a line
From:       Jan Ziak <0xe2.0x9a.0x9b () gmail ! com>
Date:       2019-03-31 19:47:50
Message-ID: CAODFU0p4FxZP34L=LAZX=25EFn6NK8vD7p47bsUu8yd+TpCb_Q () mail ! gmail ! com
[Download RAW message or body]

On Sun, 31 Mar 2019 at 21:15, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>
> Hi Jan,
>
> On Sun, Mar 31, 2019 at 8:45 PM Jan Ziak <0xe2.0x9a.0x9b@gmail.com> wrote:
> >
> > Hello
> >
> > After performing "Unstage Line From Commit" action, the "Unstaged
> > Changes" windowpane is reset. The reset does not happen with "Unstage
> > Hunk From Commit" action.
>
> because its not necessary when staging a hunk. Though when staging a
> line it is better to run the diff algorithm again.

Yes. I was thinking comparing the old state of "Unstaged Changes" to
the new state and preserving (or approximating) the selected filename
and scroller position if possible.

When unstaging a line (or a hunk) there is internally no possibility
for the currently selected filename to disappear from the "Unstaged
Changes" list.

> Anyway, which problem do you observe in particular?

The problem is that the selected filename and scroller position are
reinitialized. It is uncomfortable when "Unstaged Changes" contains a
lot of filenames.

Sincerely
Jan

> Best,
> Bert
>
> >
> > git version 2.21.0
> >
> > Sincerely
> > Jan
[prev in list] [next in list] [prev in thread] [next in thread]