[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [GSoC][PATCH v8 00/20] Convert "git stash" to C builtin
From:       Junio C Hamano <gitster () pobox ! com>
Date:       2018-08-31 18:14:36
Message-ID: xmqqzhx21jzn.fsf () gitster-ct ! c ! googlers ! com
[Download RAW message or body]

Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com> writes:

> This a new iteration of `stash.c`. What is new?
>
>  * Some commits got squashed. The commit related to replacing
>  `git apply` child process was dropped since it wasn't the best
>  idea.
>
>  * In v7, there was a bug [1] related to config `git stash show`
>  The bug was fixed and a test file was added for this.
>
>  * Fixed `git stash [push]` [2]. In v7, `git stash -q drop` would
>  act like `git stash push -q drop`.
>
>  * Fixed coding-style nits. Verified that messages are marked
>  for translation and are going to the correct output stream.
>
>  * Fixed one memory leak (related to `strbuf_detach`).
>
>  * Simplified the code a little bit.

Also worth noting.

  * Rebased on a recent 'master', in which the calling convention
    for functions like dir_path_match() has been updated.  It won't
    compile when applied to anything older than dc0f6f9e ("Merge
    branch 'nd/no-the-index'", 2018-08-20).

[prev in list] [next in list] [prev in thread] [next in thread]