[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH/RFC] clone: report duplicate entries on case-insensitive filesystems
From:       Junio C Hamano <gitster () pobox ! com>
Date:       2018-07-31 20:57:57
Message-ID: xmqqin4v9l7u.fsf () gitster-ct ! c ! googlers ! com
[Download RAW message or body]

Jeff King <peff@peff.net> writes:

>> Presumably we are already in an error codepath, so if it is
>> absolutely necessary, then we can issue a lstat() to grab the inum
>> for the path we are about to create, iterate over the previously
>> checked out paths issuing lstat() and see which one yields the same
>> inum, to find the one who is the culprit.
>
> Yes, this is the cleverness I was missing in my earlier response.
>
> So it seems do-able, and I like that this incurs no cost in the
> non-error case.

Not so fast, unfortunately.  

I suspect that some filesystems do not give us inum that we can use
for that "identity" purpose, and they tend to be the ones with the
case smashing characteristics where we need this code in the error
path the most X-<.
[prev in list] [next in list] [prev in thread] [next in thread]