[prev in list] [next in list] [prev in thread] [next in thread]
List: git
Subject: Re: [PATCH v2 09/27] transport: store protocol version
From: Derrick Stolee <stolee () gmail ! com>
Date: 2018-01-31 14:45:43
Message-ID: ae3bd6ae-7335-9aca-0818-a90e202ff37a () gmail ! com
[Download RAW message or body]
On 1/25/2018 6:58 PM, Brandon Williams wrote:
> + switch (data->version) {
> + case protocol_v1:
> + case protocol_v0:
> + refs = fetch_pack(&args, data->fd, data->conn,
> + refs_tmp ? refs_tmp : transport->remote_refs,
> + dest, to_fetch, nr_heads, &data->shallow,
> + &transport->pack_lockfile);
> + break;
> + case protocol_unknown_version:
> + BUG("unknown protocol version");
> + }
After seeing this pattern a few times, I think it would be good to
convert it to a macro that calls a statement for protocol_v1/v0 (and
later calls a different one for protocol_v2). It would at minimum reduce
the code clones surrounding this handling of unknown_version, and we
could have one place that is clear this BUG() is due to an unexpected
response from discover_version().
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic