[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH 2/2] travis-ci: record and skip successfully built trees
From:       Lars Schneider <larsxschneider () gmail ! com>
Date:       2017-12-30 19:17:18
Message-ID: 5CF879C0-021D-479C-AAA7-B9A61B126C83 () gmail ! com
[Download RAW message or body]


> On 29 Dec 2017, at 21:16, SZEDER Gábor <szeder.dev@gmail.com> wrote:
> 
> On Fri, Dec 29, 2017 at 9:03 PM, SZEDER Gábor <szeder.dev@gmail.com> wrote:
> 
>>>>> Or print it in a different color? Maybe red?
>>>>> 
>>>>> See: https://travis-ci.org/szeder/git/jobs/322247836#L622-L625
>>>> 
>>>> I considered using color for the first line, but then didn't do it,
>>>> because I didn't want to decide the color :)
>>>> Anyway, red is the general error/failure color, but this is neither.  It
>>>> could either be green, to match the color of the build job's result, or
>>>> something neutral like blue or yellow.
>>> 
>>> You are right about red. I think I like yellow to express "warning".
>>> But this is just a nit.
>> 
>> OK, yellow it will be then.
> 
> Oh, hang on!  Have a look:
> 
>  https://travis-ci.org/szeder/git/jobs/322841285#L629
> 
> That yellow is barely different from default text color.
> Bold stands out much better, but notice how Travis CI uses bold for all
> its messages.  Therefore I think we should not use bold and leave it
> exclusive to Travis CI's messages.
> 
> Green looks good:
> 
>  https://travis-ci.org/szeder/git/jobs/322372326#L629

Agreed. Green looks good! :-)

- Lars=
[prev in list] [next in list] [prev in thread] [next in thread]