[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH 01/34] am: release strbufs after use in detect_patch_format()
From:       Stefan Beller <sbeller () google ! com>
Date:       2017-08-31 17:31:56
Message-ID: CAGZ79kb4H7Ztm4tFhRNKaR4L1RM+eY30dtnTRm25xMPNWWZo2Q () mail ! gmail ! com
[Download RAW message or body]

On Wed, Aug 30, 2017 at 10:49 AM, Rene Scharfe <l.s.r@web.de> wrote:
> Don't reset the strbufs l2 and l3 before use as if they were static, but
> release them at the end instead.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>

This was introduced with 5ae41c79b8 (builtin-am: support and
auto-detect StGit patches, 2015-08-04), trying to sift through old emails
I did not find a discussion if that was static in an earlier round of the
patches.

Thanks and
Reviewed-by: Stefan Beller <sbeller@google.com>
[prev in list] [next in list] [prev in thread] [next in thread]