[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Subject: [PATCH] config: mark a file-local symbol as static
From:       Ramsay Jones <ramsay () ramsayjones ! plus ! com>
Date:       2017-06-15 1:20:20
Message-ID: 7d11fa4e-232b-8741-504f-ab4e3e788130 () ramsayjones ! plus ! com
[Download RAW message or body]


Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Sahil,

If you need to re-roll your 'sd/branch-copy' branch, could you please
squash this into the relevant patch (commit 37af9c71b6, "config: create
a function to format section headers", 13-06-2017).

Also, I note that another patch in that branch (commit fd44da469c,
"branch: add a --copy (-c) option to go with --move (-m)", 13-06-2017),
adds a couple of external symbols which, currently, don't need to be
externally visible. Is it intended that git_config_copy_section_in_file()
and refs_copy_existing_ref() be part of the public API?

Thanks!

ATB,
Ramsay Jones

 config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config.c b/config.c
index 2996e6d56..fbba17483 100644
--- a/config.c
+++ b/config.c
@@ -2173,7 +2173,7 @@ static int write_error(const char *filename)
 	return 4;
 }
 
-struct strbuf store_create_section(const char *key)
+static struct strbuf store_create_section(const char *key)
 {
 	const char *dot;
 	int i;
-- 
2.13.0
[prev in list] [next in list] [prev in thread] [next in thread]